Allow custom flags to be passed to minikube#636
Allow custom flags to be passed to minikube#636knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
Conversation
change variable name, add comments add to README simplify remove comment fix logic for parsing profile name add custom args to minikube
|
Hi @Alexander-Kita. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@dprotaso: GitHub didn't allow me to assign the following users: for, approval. Note that only knative-extensions members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Alexander-Kita, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind enhancement
Fixes #557
Release Note
Docs