Skip to content

Allow custom flags to be passed to minikube#636

Merged
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
Alexander-Kita:add-custom-args
Apr 10, 2026
Merged

Allow custom flags to be passed to minikube#636
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
Alexander-Kita:add-custom-args

Conversation

@Alexander-Kita
Copy link
Copy Markdown
Contributor

@Alexander-Kita Alexander-Kita commented Mar 4, 2026

Changes

  • Allow custom minikube flags to be passed to minikube quickstart command

/kind enhancement

Fixes #557

Release Note

"kn quickstart minikube" now accepts custom minikube flags passed, for example:

kn quickstart minikube -- ports=5000

Docs


change variable name, add comments

add to README

simplify

remove comment

fix logic for parsing profile name

add custom args to minikube
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Mar 4, 2026

Hi @Alexander-Kita. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2026
@dprotaso
Copy link
Copy Markdown
Contributor

dprotaso commented Mar 9, 2026

/ok-to-test
/lgtm
/assign @dsimansk for approval

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Mar 9, 2026

@dprotaso: GitHub didn't allow me to assign the following users: for, approval.

Note that only knative-extensions members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/ok-to-test
/lgtm
/assign @dsimansk for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2026
@dprotaso
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Alexander-Kita, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026
@knative-prow knative-prow Bot merged commit e2c4065 into knative-extensions:main Apr 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow passing custom flags to minikube

3 participants