Open default world instead of home screen on delete scene#618
Open
Open default world instead of home screen on delete scene#618
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Co-authored-by: twells <twells@kipr.org>
Co-authored-by: twells <twells@kipr.org>
…dition-fc7c Async delete reload race condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #448 by routing to
/scene/jbcSandboxinstead of/.Note
Redirects users to the default simulator scene after deleting a scene and centralizes the default scene path.
DEFAULT_SCENEconstant (/scene/jbcSandbox) and use it inDashboard.tsxandRoot.tsxRoot.tsx: close modal, navigate toDEFAULT_SCENE, then reloadDb.tsto support requestkeepaliveand set it on DELETE requests to ensure completion during navigationWritten by Cursor Bugbot for commit a740370. This will update automatically on new commits. Configure here.