Skip to content

migrate killbill-platform to jakarta namespace#194

Merged
xsalefter merged 8 commits intojava2xfrom
copilot/align-with-killbill-commons-0270
Apr 15, 2026
Merged

migrate killbill-platform to jakarta namespace#194
xsalefter merged 8 commits intojava2xfrom
copilot/align-with-killbill-commons-0270

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 14, 2026

  • Review the new PR comment and inspect the current migration branch state
  • Check recent workflow runs for java2x first, then inspect this branch for relevant build context
  • Update root-managed versions so killbill-base-plugin uses 5.2.0-a5c0ade-SNAPSHOT and killbill-api uses 0.55.0-370fa77-SNAPSHOT
  • Run targeted Maven validation for the affected dependency graph on Java 21
  • Review the resulting diffs for minimal scope, push the change, and reply to the PR comment
  • Validation note: effective POM resolves the requested snapshot overrides
  • Validation blocker: mvn -U -B -pl osgi-bundles/bundles/logger,osgi-bundles/bundles/kpm -am test cannot resolve org.kill-bill.billing:killbill-api:0.55.0-370fa77-SNAPSHOT from https://central.sonatype.com/repository/maven-snapshots/ in this environment

Copy link
Copy Markdown
Contributor

@xsalefter xsalefter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot change needed:

  1. For killbill-base-plugin version, use 5.2.0-a5c0ade-SNAPSHOT.
  2. For killbill-api version, use 0.55.0-370fa77-SNAPSHOT.

Copy link
Copy Markdown
Author

Copilot AI commented Apr 15, 2026

@copilot change needed:

  1. For killbill-base-plugin version, use 5.2.0-a5c0ade-SNAPSHOT.
  2. For killbill-api version, use 0.55.0-370fa77-SNAPSHOT.

Updated in 0eef409. The root POM now uses killbill-base-plugin:5.2.0-a5c0ade-SNAPSHOT and killbill-api:0.55.0-370fa77-SNAPSHOT. I also re-ran targeted Java 21 validation, but this environment can’t currently resolve the requested killbill-api snapshot from the configured Sonatype snapshots repository.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • central.sonatype.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/killbill-platform/killbill-platform org.codehaus.plexus.classworlds.launcher.Launcher -q help:effective-pom -Doutput=/tmp/killbill-platform-effective-pom-comment.xml (dns block)
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/killbill-platform/killbill-platform org.codehaus.plexus.classworlds.launcher.Launcher -q help:effective-pom -Doutput=/tmp/killbill-platform-effective-pom-comment2.xml (dns block)
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/killbill-platform/killbill-platform org.codehaus.plexus.classworlds.launcher.Launcher -U -B -pl osgi-bundles/bundles/logger,osgi-bundles/bundles/kpm -am test (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from xsalefter April 15, 2026 04:32
Copilot AI and others added 4 commits April 15, 2026 11:40
Agent-Logs-Url: https://github.com/killbill/killbill-platform/sessions/33d7f91b-0634-4a1a-8e43-58b493cd7a1c

Co-authored-by: xsalefter <510438+xsalefter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/killbill/killbill-platform/sessions/33d7f91b-0634-4a1a-8e43-58b493cd7a1c

Co-authored-by: xsalefter <510438+xsalefter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/killbill/killbill-platform/sessions/33d7f91b-0634-4a1a-8e43-58b493cd7a1c

Co-authored-by: xsalefter <510438+xsalefter@users.noreply.github.com>
@xsalefter xsalefter force-pushed the copilot/align-with-killbill-commons-0270 branch from 0eef409 to 8887bd2 Compare April 15, 2026 04:41
Needed because seems like with JDK21, writing to /var throws "Caused by: java.io.IOException: Permission denied"

FYI by default, the KpmProperties define bundles at /var/tmp/bundles
@xsalefter xsalefter marked this pull request as ready for review April 15, 2026 21:00
@xsalefter xsalefter merged commit e52f250 into java2x Apr 15, 2026
14 checks passed
@xsalefter xsalefter deleted the copilot/align-with-killbill-commons-0270 branch April 15, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants