Repository navigation
Conversation
The format 14 non-default UVS mappings and the Mac 1-0-0 format 0 glyph array were passed through without a range check, so a sanitized font could map a character or variation sequence to a glyph id >= numGlyphs. Reject them the same way formats 4, 12 and 13 already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmap format 0 and 14 glyph ids are not range-checked
Parse0514only rejects glyph id 0 in non-default UVS mappings, andParse100copies the Mac 1-0-0 glyphIdArray as is, so both can point past numGlyphs and are re-serialized unchanged. With a 7-glyph font carrying a UVS mapping to glyph 60000 (or a format 0 entry mappingAto glyph 200),ots-sanitizereports success and the output keeps the bad id. Formats 4, 12 and 13 already reject this. The two fonts added totests/fonts/badare those reproducers; they pass on main and are rejected with this change, and all good fonts still pass.