packaging: kill only the main Keybase process in run_keybase#28493
Open
upamanyus wants to merge 1 commit intokeybase:masterfrom
Open
packaging: kill only the main Keybase process in run_keybase#28493upamanyus wants to merge 1 commit intokeybase:masterfrom
upamanyus wants to merge 1 commit intokeybase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux, executing
run_keybasewhile Keybase is already running causes electron to crash consistently (because e.g. the electron/chromium gpu-process gets killed). This fixes that by more carefully killing only the main electron/Keybase process.A previous PR (#17463) tried to fix this, but it used
pgrep 'Keybase$'which checks for matches against the process name. Adding-fmakes it match against the full command line arguments.