fix(whatsapp): import Apple ChatStorage message type 7 - #813
Merged
Merged
Conversation
roborev: Combined Review (
|
roborev: Combined Review (
|
roborev: Combined Review (
|
Apple URL messages with non-empty text were silently skipped. Import those messages and apply the same type filter when detecting duplicate stanza IDs, so mixed text and URL duplicates cannot silently win. - fix(whatsapp): assert the blank stanza fixture value - fix(whatsapp): satisfy testify boolean assertions - docs(whatsapp): explain Apple URL message imports Generated with Codex Co-authored-by: Wes McKinney <wesmckinn+git@gmail.com> Co-authored-by: Codex <noreply@openai.com>
wesm
force-pushed
the
pr/370-apple-type-7-text
branch
from
September 9, 2026 14:41
98ae3a9 to
ec80918
Compare
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Apple WhatsApp importer now archives nonblank
ZWAMESSAGErows withZMESSAGETYPE = 7, including their message bodies, raw source data and full-text search entries. The existing Apple importer accepted only type 0, even though the type 7 rows in the archive reported by dimatosj contain ordinary text.The fix widens the Apple text guard and its duplicate stanza check together. When a type 0 row and a type 7 row share a stanza ID across chats, the duplicate pre-scan skips both rows and reports the existing duplicate error instead of letting the type 0 row win. Apple type 1 captions and other unsupported types remain skipped, blank text and stanza IDs remain skipped, and Android type 7 system messages keep their existing behavior. This builds on the Apple ChatStorage importer from #706 .
Closes #370