Skip to content

feat(people): add person directory for recent-contact CLI browsing - #811

Merged
wesm merged 2 commits into
kenn-io:mainfrom
rodboev:pr/people-directory-cli
Sep 9, 2026
Merged

wesm merged 2 commits into
kenn-io:mainfrom
rodboev:pr/people-directory-cli

Conversation

@rodboev

@rodboev rodboev commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Browse promoted people by last contact with msgvault person directory. For example, msgvault person directory --last-contact-after 2026-06-01 --sort last_contact_desc lists recent contacts through the selected local or remote daemon.

The command supports inclusive date bounds, three sort orders, and cursor pagination with the daemon’s 50-row default. Invalid dates and sort values fail locally with flag-specific errors. The human table shows ID, display name, and last contact in UTC at seconds precision; --json returns the full Directory page and preserves fractional seconds.

The change adds the CLI command, tests, and usage documentation. person list keeps its existing unpaginated behavior.

Refs #534 step 20.

@roborev-ci

roborev-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

roborev: Combined Review (91941d0)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 4m16s

@roborev-ci

roborev-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

roborev: Combined Review (c29b7f5)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 5m2s

@roborev-ci

roborev-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown

roborev: Combined Review (e12610e)

Verdict: No findings at or above medium severity.


Reviewers: 2 done | Synthesis: codex, 6s | Total: 4m46s

@wesm wesm self-assigned this Sep 9, 2026
@roborev-ci

roborev-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

roborev: Combined Review (591f962)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 4m23s

Browse promoted people by last contact through the selected daemon, with
inclusive date bounds, sort order, cursor pagination, and JSON output.
Keep human timestamps easy to scan and report invalid sort values before
connecting to the daemon.

- fix(people): preserve directory sort default for empty input
- fix(people): satisfy testify helper lint
- test(visual): widen claim renewal timing margin (reverted before squash)
- fix(people): clarify directory input errors and timestamps

Generated with Codex
Co-authored-by: Wes McKinney <wesmckinn+git@gmail.com>
Co-authored-by: Codex <noreply@openai.com>
@wesm
wesm force-pushed the pr/people-directory-cli branch from 591f962 to 6d762d3 Compare September 9, 2026 14:42
@roborev-ci

roborev-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

roborev: Combined Review (6d762d3)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 3m53s

The directory sort regression test exceeded the direct testify-call limit
checked by CI. Use the same local assertion helper as neighboring tests so
the repository's assertion-style check accepts it without changing coverage.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@roborev-ci

roborev-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown

roborev: Combined Review (39c99a5)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 3m56s

@wesm
wesm merged commit c0e0afc into kenn-io:main Sep 9, 2026
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants