Skip to content

Give the Kanon worker PR-template and testing conventions#1255

Open
kelos-bot[bot] wants to merge 2 commits into
mainfrom
kanon-config-update-latest
Open

Give the Kanon worker PR-template and testing conventions#1255
kelos-bot[bot] wants to merge 2 commits into
mainfrom
kanon-config-update-latest

Conversation

@kelos-bot

@kelos-bot kelos-bot Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the kanon-workers agent's standing instructions (agentsMD) in
kanon-development/kanon-workers.yaml with two conventions learned from recent
Kanon (kelos-dev/kanon) PR reviews. The kanon-workers agent is the one that
opens and updates PRs against the kanon repo, which has no CLAUDE.md, so
project conventions must live in the agent config.

1. PR template / label gate. After Kanon PR #8 ("Add label workflow and PR
template", merged 2026-05-30), the kanon repo enforces a check-pr-labels CI
gate: a PR keeps the blocking needs-kind / needs-release-note labels (and
fails CI) unless its body carries a /kind line and a filled release-note
block. A worker PR opened after #8 would trip this gate. Added a
## Pull Requests section requiring the agent to follow
.github/PULL_REQUEST_TEMPLATE.md — mirroring how the kelos repo's own
CLAUDE.md supplies the same guidance for self-development/kelos-workers.

2. Testing conventions. The Kanon reviewer repeatedly flagged the same
test-coverage gaps across worker PRs:

The worker agentsMD had no testing guidance at all. Added a ## Testing
section telling the agent to: test the happy path / primary action (not only
early-return guards), assert both directions of a two-outcome guard, cover
flag/scope-narrowed behavior directly, and add a negative assertion when
removing behavior. This pushes the lesson to the point where the code is
written instead of relying on review to catch the same gaps each time.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Scope is limited to kanon-development/kanon-workers.yaml. Both changes put the
convention where the kelos repo puts its equivalents — in the agent's standing
instructions — because the kanon repo has no CLAUDE.md to carry them.

Does this PR introduce a user-facing change?

NONE

@gjkim42 gjkim42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to refine kanon-development? self-development has the same instructions but it works fine.
/kelos pick-up

@kelos-bot

kelos-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Task Status

Task kelos-pr-responder-pull-request-review-658ffd796fb0 has succeeded. ✅

Add the PR-template/label-gate conventions to the kanon-workers agent's
standing instructions (agentsMD) rather than to individual procedure
steps, mirroring how the kelos repo's CLAUDE.md supplies them for
self-development. The kanon repo has no CLAUDE.md, so the worker agent
otherwise gets no template guidance and trips the new check-pr-labels
gate.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@kelos-bot kelos-bot Bot force-pushed the kanon-config-update-latest branch from acb3127 to ec8dcdc Compare June 1, 2026 00:37
@kelos-bot kelos-bot Bot changed the title Make Kanon worker follow the PR template and label gates Give the Kanon worker standing PR-template guidance for the label gate Jun 1, 2026
@kelos-bot

kelos-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Agent @gjkim42

Good question — I dug into why self-development works without this and the answer points to a real gap rather than a redundancy:

kelos-workers complies with the PR template not because of its prompt, but because the kelos repo has a CLAUDE.md ("Always follow .github/PULL_REQUEST_TEMPLATE.md…"). That standing guidance is what clears the label gate. The kanon repo has no CLAUDE.md (verified via the GitHub API and a code search), so kanon-workers got no equivalent guidance from anywhere — and after kanon PR #8 added check-pr-labels, its PRs would trip the gate.

I've reworked the change to match how self-development does it: the convention now lives in the kanon-workers-agent agentsMD (the agent's standing instructions, the kanon analog of kelos's CLAUDE.md), and the numbered procedure steps are reverted to be identical to kelos-workers. Net diff is now just a 10-line ## Pull Requests section.

If you'd prefer this live in a CLAUDE.md added to the kelos-dev/kanon repo itself (which would also cover the other kanon agents and human contributors), I'm happy to open that as a follow-up against kanon instead — let me know.

The Kanon reviewer repeatedly flagged test-coverage gaps in worker PRs:
untested happy paths and primary actions, untested guard branches in both
directions, scope-narrowed behavior exercised only indirectly, and missing
negative assertions when behavior is removed. The worker agentsMD had no
testing guidance, so add a Testing section to its standing instructions so
workers write these tests up front instead of relying on review to catch
the gaps.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@kelos-bot kelos-bot Bot changed the title Give the Kanon worker standing PR-template guidance for the label gate Give the Kanon worker PR-template and testing conventions Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant