self-development: add matrix-completeness convention to agent rules#1219
Open
kelos-bot[bot] wants to merge 1 commit into
Open
self-development: add matrix-completeness convention to agent rules#1219kelos-bot[bot] wants to merge 1 commit into
kelos-bot[bot] wants to merge 1 commit into
Conversation
Adds a new rule to AGENTS.md and the inline agentsMD copies in self-development/agentconfig.yaml and self-development/kelos-workers.yaml: > Cover the whole matrix when writing matrix-shaped tests. When a test > iterates over resource kinds, agent types, or subcommands, include > every member of that set that supports the behavior under test. If a > member is deliberately omitted, leave an inline comment naming the gate. Motivated by repeated reviewer feedback that agents ship partial-coverage matrix tests: - PR #1180 (Drop ValidArgsFunction from kelos create workspace): three rounds of CHANGES_REQUESTED on internal/cli/completion_test.go before the agent covered the full resource set or named the omission gate. - PR #1175 (Drop removed --enable skills flag from codex entrypoint): reviewer asked the agent to parametrize the new e2e test across the agentConfigs matrix instead of writing a codex-only file. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Kelos Agent @gjkim42
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds one new convention to
AGENTS.md(withCLAUDE.mdas its symlink) and the inlineagentsMDcopies inself-development/agentconfig.yamlandself-development/kelos-workers.yaml:Motivating review feedback
This rule is backed by repeated reviewer feedback that agent-authored matrix tests ship with partial coverage and have to be expanded after-the-fact:
PR Drop ValidArgsFunction from 'kelos create workspace' #1180 (
Drop ValidArgsFunction from 'kelos create workspace') — three rounds of @gjkim42 review oninternal/cli/completion_test.go:44before the test was accepted:Had the agent either (a) covered every resource or (b) left an inline
// task and taskspawner have no create subcommandcomment on the first pass, the round-trip would have collapsed to zero turns.PR Drop removed --enable skills flag from codex entrypoint #1175 (
Drop removed --enable skills flag from codex entrypoint) — @gjkim42 ontest/e2e/skills_test.go: "this should not be a codex specific e2e test." The agent had to rewrite the test to iterate overagentConfigsafter the fact. Same shape: a test that should have been matrix-shaped from the start was shipped agent-specific.Scope notes
self-development/*.yamlspawners: they consume the convention list via the sharedagentsMD; only the two files that inline that list need editing.CLAUDE.mdis a symlink toAGENTS.md, so a single edit covers both surfaces.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?
Summary by cubic
Add a “cover the whole matrix” testing convention to
AGENTS.mdand the inline copies inself-development/agentconfig.yamlandself-development/kelos-workers.yaml. Tests that iterate over resources/agents/subcommands must include all supported members or explain omissions inline, improving coverage and reducing review churn.Written for commit ebf2911. Summary will update on new commits. Review in cubic