self-development: sweep sibling TaskSpawners when changing webhook filters#1214
Open
kelos-bot[bot] wants to merge 1 commit into
Open
self-development: sweep sibling TaskSpawners when changing webhook filters#1214kelos-bot[bot] wants to merge 1 commit into
kelos-bot[bot] wants to merge 1 commit into
Conversation
…lters Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds two recurring TaskSpawner conventions to
self-development/agentconfig.yamlandself-development/kelos-workers.yaml(the two files that carry the inline `agentsMD` rule list seen by the dev/worker agents). Both rules slot under the existing TaskSpawner conventions block.Motivating review feedback
Both rules come from PR #1205 (`self-development: scope kelos-planner, kelos-reviewer, and kelos-api-reviewer with commentOn`), where the agent's first iteration only updated two of three sibling spawners and used a single scoped filter on a dual-mode spawner:
The convention block in the two YAMLs is the right home: it already lists TaskSpawner-specific guidance (`{{.Branch}}` handling, `issue_comment` dual-fire, no manual PR checkout) and is the rule set both `kelos-dev-agent` (the self-development agent) and `kelos-workers-agent` actually consume.
Scope notes
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?
```release-note
NONE
```
Summary by cubic
Added two new recurring TaskSpawner conventions to
self-development/agentconfig.yamlandself-development/kelos-workers.yamlbased on feedback from PR #1205, where a webhook filter change missed sibling spawners and incorrectly used a single scoped filter on a dual-mode prompt.self-development/and update every match or document intentional exclusions.commentOn: IssuevscommentOn: PullRequest) — prompts that branch ongh pr viewneed two filter entries, not one.Written for commit 267d7bb. Summary will update on new commits. Review in cubic