Skip to content

self-development: have workers self-review and squash commits before signaling ready#1210

Closed
kelos-bot[bot] wants to merge 1 commit into
mainfrom
kelos-config-update-20260524-1800
Closed

self-development: have workers self-review and squash commits before signaling ready#1210
kelos-bot[bot] wants to merge 1 commit into
mainfrom
kelos-config-update-20260524-1800

Conversation

@kelos-bot

@kelos-bot kelos-bot Bot commented May 24, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the kelos-workers and kelos-pr-responder prompts to add two recurring asks from the last week of /kelos pick-up review feedback:

  1. Self-review locally before requesting /review. The agent should re-read git diff origin/main...HEAD, run make verify and make test, and fix obvious issues itself before asking the reviewer agent to look.
  2. Squash commits before signaling the PR is ready. A new final step rebases-then-squashes all branch commits into a single commit and force-pushes — only when there are 2+ commits since the merge base.

Motivating review feedback from PRs merged/active this week (all from @gjkim42):

The existing kelos-squash-commits TaskSpawner stays as the explicit /kelos squash-commits escape hatch — this change just makes squashing the default for normal worker/responder runs so maintainers don't have to ask each time.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

  • The squash step lives after the CI-check step (9 / 9a / 8b). The note "the squash does not change the tree, so CI results remain valid" tells the agent not to re-wait for checks after the force-push.
  • Skipped when there is only one commit since the merge base, to avoid pointless force-pushes.

Does this PR introduce a user-facing change?

NONE

Summary by cubic

Have kelos-workers and kelos-pr-responder self-review changes and squash commits before marking a PR ready. This reduces reviewer churn and keeps PR history clean.

  • Refactors
    • Add local self-review before /review (read git diff origin/main...HEAD, run make verify and make test).
    • Add final squash step: make a single commit; skip if only one since merge base; git push --force-with-lease.
    • Place squashing after CI; tree is unchanged, so no need to re-wait checks.

Written for commit 8498cda. Summary will update on new commits. Review in cubic

…mits

Adds two recurring asks from recent /kelos pick-up review feedback to the
worker and pr-responder prompts:

- Self-review the diff locally before requesting /review (run make verify
  and re-read the diff)
- Squash all commits on the branch into one before signaling the PR is
  ready for human review

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added needs-triage kind/cleanup needs-priority needs-kind Indicates an issue or PR lacks a kind/* label needs-actor release-note-none and removed needs-kind Indicates an issue or PR lacks a kind/* label labels May 24, 2026
@gjkim42

gjkim42 commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Should not always squash commits

@gjkim42 gjkim42 closed this May 27, 2026
@gjkim42 gjkim42 deleted the kelos-config-update-20260524-1800 branch May 27, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant