self-development: have workers self-review and squash commits before signaling ready#1210
Closed
kelos-bot[bot] wants to merge 1 commit into
Closed
self-development: have workers self-review and squash commits before signaling ready#1210kelos-bot[bot] wants to merge 1 commit into
kelos-bot[bot] wants to merge 1 commit into
Conversation
…mits Adds two recurring asks from recent /kelos pick-up review feedback to the worker and pr-responder prompts: - Self-review the diff locally before requesting /review (run make verify and re-read the diff) - Squash all commits on the branch into one before signaling the PR is ready for human review Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
|
Should not always squash commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates the
kelos-workersandkelos-pr-responderprompts to add two recurring asks from the last week of/kelos pick-upreview feedback:/review. The agent should re-readgit diff origin/main...HEAD, runmake verifyandmake test, and fix obvious issues itself before asking the reviewer agent to look.Motivating review feedback from PRs merged/active this week (all from @gjkim42):
self-development: workers request review via /kelos review): "You still need to review your coee locally in addition to the kelos review. Then squash commits." — covers both asks in one comment.The existing
kelos-squash-commitsTaskSpawner stays as the explicit/kelos squash-commitsescape hatch — this change just makes squashing the default for normal worker/responder runs so maintainers don't have to ask each time.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Summary by cubic
Have
kelos-workersandkelos-pr-responderself-review changes and squash commits before marking a PR ready. This reduces reviewer churn and keeps PR history clean./review(readgit diff origin/main...HEAD, runmake verifyandmake test).git push --force-with-lease.Written for commit 8498cda. Summary will update on new commits. Review in cubic