Closed
Conversation
Previously, tests required a running stack of Docker services (ZooKeeper, Solr, PostgreSQL, LDAP, MailHog) either via docker-compose or pre-started GitHub Actions service containers. LDAP was already managed via Testcontainers; this change extends the same pattern to the remaining services. Key changes: - TestContainersManager: singleton that starts ZooKeeper, Solr (Cloud mode), and PostgreSQL containers once per test suite run, then sets the system properties that ConfigurationManager and Spring Boot read for connection URLs. - RodaContainersLifecycleListener: TestNG ISuiteListener registered in testng.xml so containers start (and system properties are set) before any test class is instantiated or any Spring context is initialised. - ConfigurationManager.getConfigurationString: now checks System.getProperty as a fallback between the OS environment variable and the config file, allowing test helpers to override settings without forking the JVM. - CI.yml: removes the ZooKeeper, Solr, PostgreSQL, and MailHog service container definitions and their corresponding environment variable overrides; the test suite now self-provisions all required infrastructure via Testcontainers. https://claude.ai/code/session_01KuXDU1UWFJrTiZWK2hqPVj
dosubot
bot
added
the
size:XXL
dosubot
bot
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.