feat: Allow installing and testing with all database types, including MariaDB#34
feat: Allow installing and testing with all database types, including MariaDB#34rfay wants to merge 12 commits intojustafish:mainfrom
Conversation
Co-authored-by: Christian López Espínola <penyaskito@penyaskito.com>
|
@rfay Could you rebase this against |
|
Ah drat, I hadn't seen this depended on #33. Too many balls in the air, sorry! |
|
I don't know if in my fork I want to support both styles of installation, or just using my Composer project template. I was initially thinking I'd support both, if it's not too much faff. |
This is part of justafish#31 Rebase will be required when that goes in.
0d8d9b1 to
90eeb91
Compare
|
This is rebased against
But of course it still depends on #33. |
All I care about here is using a "normal" database type, and having drush available. I'm pretty sure your template is a fine way to do that, true? |
|
Yup, but what I mean is if I drop support for running this directly in a Drupal core clone, then none of #33 is needed. |
|
Again, any way you get drush works for me :) |
| ;; | ||
| esac | ||
| fi | ||
| perl -pi -e "s|SIMPLETEST_DB_VALUE|${dburl}|g" core/phpunit.xml |
There was a problem hiding this comment.
@rfay is it intentional that this is still using the sqlite DB for running PHPUnit tests?
There was a problem hiding this comment.
Actually, this was using mariaDB by accident until a recent PR. But IMO it should use mariaDB by default and allow using any supported database. That's actually why I started working on this PR a bit, because I wanted to see "real" performance comparisons on Drupal, comparing DB types. I think it's possible that the use of sqlite3 "for performance reasons" may be obsolete.
(Draft: This has to be rebased after
This PR allows using any database type supported by DDEV, including MariaDB and MySQL. And of course it can still use sqlite.
It currently includes unmerged PRs because drush is required for it.
I guess it still needs tests, will wait until after rebase.