Conversation
|
Thank you for the PR. Code in the PR states that https://code.google.com/p/msysgit/ is required. My understanding is that |
|
msysgit doesn't include development tools. make is not in the distribution (I checked 1.8.4 and 1.9.0). |
|
Thank you for checking that. I am not inclined to merge this PR as is due to the following reasons.
My understanding is that users may install jsx on Windows using npm and they can also install make to develop JSX. Please correct me if I am wrong. |
|
I made this script to test issue #316. If the fix would be published (it seems not to be published yet), the priority weill be low. It is a first version. In future, I will find other Winows issues, I will create other target too. |
|
Understood, though I would advise to implement the tests as part of the test suite (instead of copy-pasted build script) so that we could automatically detect regressions. Regarding the next release, I would like to wait for #309 get finished, since I do not want to occasionally introduce incompatibilities in the toolchain (and we have already merged #313 that does this). |
No description provided.