Conversation
Owner
Author
jstedfast
force-pushed
the
imap-token-cache
branch
from
August 27, 2023 02:54
a50f9a2 to
7632855
Compare
jstedfast
force-pushed
the
imap-token-cache
branch
from
September 2, 2023 16:38
ba9a703 to
3b06559
Compare
jstedfast
force-pushed
the
imap-token-cache
branch
from
September 4, 2023 14:57
60a4c1f to
ad10894
Compare
jstedfast
force-pushed
the
imap-token-cache
branch
from
September 4, 2023 15:02
ad10894 to
e3bac2b
Compare
jstedfast
force-pushed
the
imap-token-cache
branch
from
September 4, 2023 15:14
e3bac2b to
096174d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Theoretically, this could drastically reduce ImapToken allocations which might help with issue #1335.
Of course, this also adds more overhead in other aspects.
TODO:
ImapTokenCacheImapEngine-specific? Might be better than a globalImapTokencache like it is now. Another advantage of that would be that the mutex locking wouldn't be necessary anymore. Not sure how expensive locking is...Alternative Idea:
Instead of (or in combination with?) the
ImapTokenCache, if we usedReadOnlyMemory<byte>, we wouldn't need:This would reduce memory allocations, memory fragmentation, and improve performance because there'd be no (or less) need to copy data around.
That said, there are a few things to consider: