Fix/1056 openapi capabilities#1905
Draft
mrnlts wants to merge 4 commits intojson-api-dotnet:masterfrom
Draft
Conversation
…ased on attribute capabilities (json-api-dotnet#1056)
…ased on relationship capabilities (json-api-dotnet#1056)
Member
|
Thanks! It looks like the failing tests reveal bugs. Can you try fixing them? And can you also fix the style issues? How about coverage for I'm a bit confused about the added resource types. For example, |
bkoelman
reviewed
Jan 31, 2026
|
|
||
| // Assert | ||
| document.Should().NotContainPath("paths./articles/{id}/relationships/categories.post"); | ||
| document.Should().NotContainPath("paths./books/{id}/relationships/reviews.post"); |
Member
There was a problem hiding this comment.
Please assert that the parent path exists before asserting the child does not (similar to other tests in this file). This way, if the parent gets renamed in the future, the test won't silently break.
Member
|
@mrnlts Are you still working on this? |
Member
|
@mrnlts Because you're not responding, I'm going to assume you lost interest in continuing to work on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1056
QUALITY CHECKLIST