-
-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add TypeScript definitions #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bjohansebas
wants to merge
4
commits into
jshttp:master
Choose a base branch
from
bjohansebas:add-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4176e7f
feat: add TypeScript definitions
bjohansebas b60a628
fix: update npm-rm list for Node.js jobs and ensure type tests run co…
bjohansebas 2e17199
feat: restructure TypeScript test job in CI workflow
bjohansebas 557daa9
feat: add npm version fixes for Node.js jobs in CI workflow
bjohansebas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** | ||
| * When ranges are returned, the array has a "type" property which is the type of | ||
| * range that is required (most commonly, "bytes"). Each array element is an object | ||
| * with a "start" and "end" property for the portion of the range. | ||
| * | ||
| * @returns `-1` when unsatisfiable and `-2` when syntactically invalid, ranges otherwise. | ||
| */ | ||
| declare function RangeParser( | ||
| size: number, | ||
| str: string, | ||
| options?: RangeParser.Options, | ||
| ): RangeParser.Result | RangeParser.Ranges; | ||
|
|
||
| declare namespace RangeParser { | ||
| interface Ranges extends Array<Range> { | ||
| type: string; | ||
| } | ||
| interface Range { | ||
| start: number; | ||
| end: number; | ||
| } | ||
| interface Options { | ||
| /** | ||
| * The "combine" option can be set to `true` and overlapping & adjacent ranges | ||
| * will be combined into a single range. | ||
| */ | ||
| combine?: boolean | undefined; | ||
| } | ||
| type ResultUnsatisfiable = -1; | ||
| type ResultInvalid = -2; | ||
| type Result = ResultUnsatisfiable | ResultInvalid; | ||
| } | ||
|
|
||
| export = RangeParser; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import * as RangeParser from "../index.js"; | ||
| import { expectTypeOf } from "expect-type" | ||
|
|
||
| expectTypeOf(RangeParser).toBeFunction(); | ||
| expectTypeOf(RangeParser).toEqualTypeOf<( | ||
| size: number, | ||
| str: string, | ||
| options?: RangeParser.Options, | ||
| ) => RangeParser.Result | RangeParser.Ranges>(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "target": "es5", | ||
| "lib": [ "es2015" ], | ||
| "module": "commonjs", | ||
| "noEmit": true, | ||
| "strict": true | ||
| }, | ||
| "include": [ | ||
| "./test/**/*.ts", | ||
| "./**/*.d.ts" | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so that CI passes we don’t need to test the types on every Node.js version.