Skip to content

fix: add updated era codes to EthiopicHelper#357

Open
kabaros wants to merge 1 commit into
js-temporal:mainfrom
kabaros:patch-1
Open

fix: add updated era codes to EthiopicHelper#357
kabaros wants to merge 1 commit into
js-temporal:mainfrom
kabaros:patch-1

Conversation

@kabaros

@kabaros kabaros commented Mar 26, 2026

Copy link
Copy Markdown

This adds the updated era codes for Ethiopic calendar to reflect the updates in CLDR48 https://cldr.unicode.org/downloads/cldr-48#identifiers

Dealing with Ethiopian calendars started failing in the polyfill in versions of node after 20.19 (and after recent browser updates in Firefox) as ICU updated the era codes: https://unicode-org.atlassian.net/browse/ICU-23167. In the polyfill code, the ecamscript module seems to delegate to call the calendar module passing the updated era code, but the calendar module then can't match the era code failing with RangeError: Era am (ISO year 2016) was not matched by any era.

We observed the failure on CI first as node updated the ICU, but then it started failing on Firefox after an update. It currently works on Chrome stable, but fails with the same error on Canary: https://developers.dhis2.org/demo/?path=/story/calendarinput--ethiopic-with-amharic

@kabaros

kabaros commented Mar 27, 2026

Copy link
Copy Markdown
Author

@ptomato I'd appreciate a review please for this one as it completely broke the Ethiopian calendar for us (or a workaround if there is one!) .. thank you in advance 🙏🏿

@fabon-f

fabon-f commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

@kabaros
Sorry to advertise my project here, but FYI I made another polyfill supporting the latest spec including era codes of Ethiopian. You can use it for now:
https://github.com/fabon-f/temporal-polyfill-lite (You need to use temporal-polyfill-lite/calendars-full entry point for non-ISO calendars)

This adds the updated era codes for Ethiopic calendar to reflect the updates in CLDR48 https://cldr.unicode.org/downloads/cldr-48#identifiers

@ptomato ptomato left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I intend to get the polyfill updated in the next few days to match the status of the proposal at the time of moving to stage 4, and I'll rebase and merge this afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants