Initial support for analyzing categories.#45
Initial support for analyzing categories.#45fabianfreyer wants to merge 1 commit intojonpalmisc:devfrom
Conversation
|
|
|
@dlevi309 good catch! I even forgot to add another file, fixed that! |
No prob 👍 happens all the time lol |
|
Aaaand rebased onto v2.2.0 |
jonpalmisc
left a comment
jonpalmisc
left a comment
There was a problem hiding this comment.
Looks good barring a few minor issues mentioned in the comments. There is also some inconsistent whitespace which can be resolved by running the format task provided by CMakeLists.txt.
| @@ -0,0 +1,81 @@ | |||
| #include <ObjectiveNinjaCore/Analyzers/ClassAnalyzer.h> | |||
There was a problem hiding this comment.
This file is also missing a copyright header
| @@ -0,0 +1,81 @@ | |||
| #include <ObjectiveNinjaCore/Analyzers/ClassAnalyzer.h> | |||
| #include <ObjectiveNinjaCore/Analyzers/ClassAnalyzer.h> | ||
| #include <ObjectiveNinjaCore/Analyzers/CategoryAnalyzer.h> | ||
|
|
||
| #include <ObjectiveNinjaCore/TypeParser.h> |
There was a problem hiding this comment.
Also unnecessary to #include <ObjectiveNinjaCore/TypeParser.h> (although ClassAnalyzer.cpp makes this mistake too, not your fault)
3 participants
No description provided.