Repository navigation
Conversation
With wrap-search disabled, the reverse scan excludes index zero and misses a merge at the top of the main view. Include that boundary and add coverage for merge navigation with and without wrapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
wrap-search = no,move-prev-mergefails to reach a merge on the first line of the main view. From the second commit, the cursor stays put because the reverse scan excludes index zero.Include the first line in the reverse scan with a one-line boundary fix. Add a regression test covering that case, both non-wrapping boundaries, and previous/next merge navigation with wrapping enabled.
Validation:
5a8fd507and passes with this change.diff-highlightis unavailable).