added Multi-screen support for windows#16
Open
pratikUpforcetech wants to merge 1 commit intojohnvmt:masterfrom
Open
added Multi-screen support for windows#16pratikUpforcetech wants to merge 1 commit intojohnvmt:masterfrom
pratikUpforcetech wants to merge 1 commit intojohnvmt:masterfrom
Conversation
ggcaponetto
reviewed
Mar 8, 2024
|
|
||
| var nircmd = childProcess.spawn(path.join(__dirname, "bin", "nircmd.exe"), ["savescreenshot", options.output]); | ||
| var nircmd = childProcess.spawn(path.join(__dirname, "bin", "nircmd.exe"), [ | ||
| "savescreenshotfull", |
There was a problem hiding this comment.
I think it might be a better idea to use an option for the full screen. This most probably would break previous implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have placed the latest nircmd.exe and update bit code so this module can capture a multiscreen screenshot in windows.