Skip to content

Fix ICP client wiring and missing deployment exports#44

Closed
johnnyclem wants to merge 1 commit into
mainfrom
codex/fix-icp-client-wiring-and-exports
Closed

Fix ICP client wiring and missing deployment exports#44
johnnyclem wants to merge 1 commit into
mainfrom
codex/fix-icp-client-wiring-and-exports

Conversation

@johnnyclem

Copy link
Copy Markdown
Owner

Motivation

  • createICPClient previously required an HttpAgent while callers passed only a config, causing invalid client construction and broken deployment flow.
  • validateWasmPath and calculateWasmHash were referenced as standalone imports but only existed as instance methods, preventing reuse by the deployer.
  • generateStubCanisterId was exported from the barrel but not implemented, making the deployment index export incorrect.

Description

  • Updated ICPClient to accept only an ICPClientConfig and changed createICPClient to createICPClient(config) to align construction across call sites (file: src/deployment/icpClient.ts).
  • Added and exported standalone helpers validateWasmPath, calculateWasmHash, and generateStubCanisterId, and refactored the instance methods validateWasmPath and calculateWasmHash to delegate to these helpers (file: src/deployment/icpClient.ts).
  • Restored consistency between the deployment barrel and implementation so imports used by deployAgent and getCanisterStatus are valid (affects src/deployment/deployer.ts and src/deployment/index.ts).

Testing

  • No automated tests were run on this change.

Codex Task

@vercel

vercel Bot commented Apr 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-vault Error Error Apr 26, 2026 2:33pm
agentvault Error Error Apr 26, 2026 2:33pm

Copy link
Copy Markdown
Owner Author

Closing as superseded. This branch was created from a pre-rewrite history (no common ancestor with current main, so the conflict cannot be resolved by merging), and everything it fixes already exists on main:

  • ICPClient constructor takes only ICPClientConfig, and createICPClient(config) matches (src/deployment/icpClient.ts)
  • generateStubCanisterId is implemented and exported from the deployment barrel
  • deployAgent/getCanisterStatus use the client's instance methods, so no standalone validateWasmPath/calculateWasmHash exports are needed

No remaining diff to merge.


Generated by Claude Code

@johnnyclem johnnyclem closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant