Open
Conversation
added 3 commits
October 11, 2017 19:09
This avoids following error in Python3: “TypeError: a bytes-like object is required, not 'str’”
Codecov Report
@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
- Coverage 97.25% 97.06% -0.19%
===========================================
Files 14 14
Lines 1455 1500 +45
===========================================
+ Hits 1415 1456 +41
- Misses 40 44 +4
Continue to review full report at Codecov.
|
|
This is great! A jmespath matcher in Ansible is exactly what I need. Are there any plans on merging this soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Yet jmespath is powerful, there's still room for a improvement on string-based query.
In this PR, I added regex matcher, like Jayway's jsonpath do.
I believe this will bring greater power to query on complex data.
All I did is implementation, and is nothing to do with specs or docs.
c.f.: jmespath/jmespath.site#29
Example
Given:
{ "sshd_configs": [ {"hostname": "bastion", "body": "Port 22\nPort 443\n#ListenAddress ::\n#ListenAddress 0.0.0.0\n"}, {"hostname": "web1", "body": "Port 22\nListenAddress 192.168.1.10\n"}, {"hostname": "web2", "body": "Port 22\n#ListenAddress 192.168.1.10\n"} ] }Then,
👉
["bastion"]or,
👉
["web1", "web2"]