Skip to content

Added reading pgn library from binary - #30

Open
nurmukhametdaniyar wants to merge 1 commit into
jmagnuson:masterfrom
ION-Mobility-Team-Old:feature/reading_from_buffer
Open

Added reading pgn library from binary#30
nurmukhametdaniyar wants to merge 1 commit into
jmagnuson:masterfrom
ION-Mobility-Team-Old:feature/reading_from_buffer

Conversation

@nurmukhametdaniyar

Copy link
Copy Markdown

Hey

I started using this library and encountered the problem where I need to read from buffer instead of reading from a file, so I added a small function to read from buffer

Hope it helps

@nurmukhametdaniyar

Copy link
Copy Markdown
Author

I was also able to avoid issue #24 after using reading from the buffer

@jmagnuson

Copy link
Copy Markdown
Owner

Thanks, I like this idea. I wonder if there's a way to generalize it to take a iterator of bytes, maybe using something like Bytes or something compatible with nom? That should help more constrained systems which might not have the ability to buffer the entire dbc. I'll take a look soon if someone doesn't beat me to it.

@codecov

codecov Bot commented Jan 7, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.09%. Comparing base (116c4cd) to head (2d71923).

Files with missing lines Patch % Lines
src/pgn.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   68.88%   67.09%   -1.79%     
==========================================
  Files           5        5              
  Lines         601      617      +16     
==========================================
  Hits          414      414              
- Misses        187      203      +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants