Fix FutureWarning in team_results.py#500
Open
yasumorishima wants to merge 1 commit intojldbc:masterfrom
Open
Conversation
Replace deprecated chained assignment with direct assignment to avoid FutureWarning in pandas 3.0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FutureWarningcaused by chained assignment withinplace=Trueinteam_results.py(line 75)df['Attendance'].replace(..., inplace=True)withdf['Attendance'] = df['Attendance'].replace(...)as recommended by pandasCloses #459
Details
pandas 3.0 deprecates chained assignment using inplace methods. The fix follows the recommended pattern from the warning message.
Before:
After: