Skip to content

Normalised composer.json.#298

Merged
AlexSkrypnyk merged 1 commit intomasterfrom
feature/normalize-composerjson
Mar 2, 2026
Merged

Normalised composer.json.#298
AlexSkrypnyk merged 1 commit intomasterfrom
feature/normalize-composerjson

Conversation

@AlexSkrypnyk
Copy link
Collaborator

@AlexSkrypnyk AlexSkrypnyk commented Mar 2, 2026

Summary by CodeRabbit

  • Chores
    • Standardized editor configuration across the repository for consistent formatting.
    • Enhanced CI validation to ensure composer configuration normalization.
    • Updated Git ignore patterns for improved development environment consistency.
    • Reorganized and expanded package manifest configuration for clearer dependency and build management.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Warning

Rate limit exceeded

@AlexSkrypnyk has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d133e64 and b260b60.

📒 Files selected for processing (4)
  • .editorconfig
  • .github/workflows/ci.yml
  • .gitignore
  • composer.json
📝 Walkthrough

Walkthrough

The pull request standardizes development environment configuration, enhances CI/CD verification, refactors ignore patterns for clarity, and restructures the package manifest with expanded metadata and development tooling declarations.

Changes

Cohort / File(s) Summary
Editor & Git Configuration
.editorconfig, .gitignore
Adds editor configuration to enforce consistent formatting (LF line endings, 2-space indentation, UTF-8 charset, trailing whitespace trimming). Refactors .gitignore with generalized wildcard patterns and explicit directory-level ignores, plus additions for phpunit cache and git metadata.
Continuous Integration
.github/workflows/ci.yml
Introduces new CI step to validate composer.json normalization using composer normalize --dry-run within the PHP container.
Package Manifest
composer.json
Restructures manifest with reorganized top-level declarations including expanded authors, homepage, dependency blocks (require/require-dev), conflict declarations, repositories, stability settings, autoload PSR-0 mapping, plugin configuration allowlist, and lifecycle scripts including new test entry.

Poem

A rabbit hops through config files with glee,
Normalizing spaces, two, not three,
The composer sings in structured song,
CI workflows checking all day long,
Order blooms where chaos used to be! 🐰✨

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Normalised composer.json' directly and accurately summarizes the main change: normalizing the composer.json file, which is confirmed by the substantial restructuring shown in the summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/normalize-composerjson

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
composer.json (1)

17-17: Prefer HTTPS for homepage URL.

Line 17 can use https:// instead of http:// for consistency and transport security.

Suggested fix
-    "homepage": "http://github.com/jhedstrom/DrupalDriver",
+    "homepage": "https://github.com/jhedstrom/DrupalDriver",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@composer.json` at line 17, Update the composer.json "homepage" entry to use
HTTPS instead of HTTP: locate the "homepage" key whose value is
"http://github.com/jhedstrom/DrupalDriver" and change it to
"https://github.com/jhedstrom/DrupalDriver" to ensure secure, consistent
transport.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@composer.json`:
- Around line 90-91: The environment variable assignment is currently applied to
the cd command instead of the rector binary; update both script entries so
XDEBUG_MODE=off precedes the rector invocation (e.g., keep "cd drupal &&" but
move XDEBUG_MODE=off to directly before "../vendor/bin/rector") for the two
strings referencing "../vendor/bin/rector process
../src/Drupal/Driver/Cores/Drupal8.php --dry-run" and "../vendor/bin/rector
process ../src/Drupal/Driver/Fields/Drupal8 --dry-run" so the variable applies
to the rector process.

---

Nitpick comments:
In `@composer.json`:
- Line 17: Update the composer.json "homepage" entry to use HTTPS instead of
HTTP: locate the "homepage" key whose value is
"http://github.com/jhedstrom/DrupalDriver" and change it to
"https://github.com/jhedstrom/DrupalDriver" to ensure secure, consistent
transport.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a0780a and d133e64.

📒 Files selected for processing (4)
  • .editorconfig
  • .github/workflows/ci.yml
  • .gitignore
  • composer.json

@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/normalize-composerjson branch from d133e64 to 211f435 Compare March 2, 2026 23:26
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/normalize-composerjson branch from 16dfbf0 to b260b60 Compare March 2, 2026 23:36
@AlexSkrypnyk AlexSkrypnyk merged commit 85aa982 into master Mar 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant