Merged
Conversation
added 2 commits
December 24, 2025 17:02
- change `:key` and `:key` to take into account a string that is not allowed to be used in ExpresssionAttributeNames
- before, this would throw an error during the DB update `updateExpression({'a|b': true})`
- even though 'a|b' is valid as an attribute for a db row in dynamodb, just not as an alias
- updated all of the paths inside of updateExpression() so that consistently makes the key name safe before using it as an alias, not just using it as-is
- actual key is untouched and still used in the write as the attribute
- instead of using char+ -> _
- use char -> `_x${char.charCodeAt(0).toString(16)}_` (basically char code surrouned by underscores)
chwagssd
commented
Dec 29, 2025
chwagssd
commented
Dec 29, 2025
codyjmoody
approved these changes
Dec 29, 2025
jgilbert01
reviewed
Dec 30, 2025
jgilbert01
approved these changes
Dec 30, 2025
petermyers
approved these changes
Dec 30, 2025
jgilbert01
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#some-keyand:some-keyto take into account a string that is not allowed to be used in ExpresssionAttributeNamesupdateExpression({'some-key': true})