Backport fixes and test suite from tokio-postgres-rustls-improved#35
Open
dsykes16 wants to merge 11 commits intojbg:masterfrom
Open
Backport fixes and test suite from tokio-postgres-rustls-improved#35dsykes16 wants to merge 11 commits intojbg:masterfrom
dsykes16 wants to merge 11 commits intojbg:masterfrom
Conversation
Add integration test suite that uses `bollard` to create postgres containers. Includes SCRAM/SASL (i.e. channel_binding) tests and mTLS tests.
Remove original test from upstream. It used zero cert verification, no client auth, and no channel binding. The new integration test suite supersedes this test.
The main `lib.rs` uses imports (e.g. `MakeTlsConnect`) that are behind the `runtime` feature gate in `tokio-postgres` so it is NOT a development-only dependency.
Bump version from `0.13.0` to `0.14.0` and add all contributors with two or more commits to `authors` list (in-order of number of commits).
- Refactor channel binding code - Remove hard dependency on `ring` - Default to `aws-lc-rs` feature - Add optional `ring` feature - Add test run w/ `ring` feature to CI pipeline
Owner
|
Thanks for this! I merged the channel binding fix & the pin projection improvement before I saw this. Can you rebase this against master and drop those two commits and that should resolve the conflicts. (I can also do this if you adjust the PR settings to allow me to push to the PR branch.) |
|
@dsykes16, if you don't have time to rebase, you think you could accommodate the request above to move this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo seems abandoned, nevertheless I wanted to perform my due diligence in offering this PR to backport the fixes from https://github.com/khorsolutions/tokio-postgres-rustls-improved/
DOCKER_HOSTenv var is set appropriately if running a non-standard config).ringaws-lc-rsfeature (same asrustlsdefault for some time)ringfeatureringfeature to CI pipeline