Reject failed input streams - #1486
Conversation
|
CI follow-up: the six Windows x64 MinGW jobs built successfully but hung in CTest when launched under Git Bash. In that shell, |
SGSSGene
left a comment
There was a problem hiding this comment.
Thank for this fix! Especially finding the issue in the CI.
Short remark: This PR now contains three changes:
- fixing bad input streams
- fixing CI
- and cleanup raw pointers -> std::unique_ptr
I would prefer to have the raw pointers -> std::unique_ptr in a separately PR. It makes following the changes easier.
But again! This fixes are appreciated!
Fixes #408
LoadandLoadAllTests:
build :allandtest test