Fix #2219: specify the automatic UIPanel for a multi-child f:facet - #2220
Merged
Conversation
"Using Facets" required one and only one child per facet tag, with footnote 10 pointing at h:panelGroup, while the f:facet Vdldoc has stated since 2.3 that the children of a facet holding more than one of them are automatically put in a container UIPanel. Implementations do the latter. The prose now states the one-child, multi-child and pass-through-attributes-only cases, and footnote 10 becomes a recommendation for when the component type, renderer type or client identifier of the container matters. The facet bullet in "Creating Components and Overriding Attributes" is split along the same lines, so that a facet name already holding another component wraps in the automatically created UIPanel instead of dropping the tag. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Approved by MyFaces in #2219 (comment) |
# Conflicts: # spec/src/main/asciidoc/ChangeLog.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2219.
What
"Using Facets" in Standard Tag Libraries required a facet tag to have "one and only one child UIComponent tag", with footnote 10 sending page authors to
<h:panelGroup>for more than one, while thef:facetVdldoc has stated since 2.3 that "When the facet contains more than one child the children will be automatically put in a container UIPanel". Implementations do the latter. The prose predates the 2.3 addition and was never reconciled with it; its only revision was the pass-through-attributes carve-out (#2032), which reads as if that were the sole case where an automaticUIPanelappears.Three sites:
UIPanelfacet holding them, no child but pass through attributes yields an empty one.UIPanelunless it already is one, move the existing facet into it, add this one).<h:panelGroup>still buys control over the component type, renderer type and client identifier of the container, which the automatic panel does not offer.Plus a Change Log entry.
Testing
mvn clean packageinspec/renders HTML and PDF without warnings.That the implicit panel is specified behaviour also settles eclipse-ee4j/mojarra#5885, where a
UIInputinside a multi-child facet lost its submitted value and invalid state on the render-time Facelets refresh — a conformance bug, fixed in eclipse-ee4j/mojarra#5886, with TCK coverage in #2218.🤖 Generated with Claude Code (Opus 5)