Add support for v30.0 #41
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,7 @@ jobs: | |
| - typesense: '29.0' | ||
| otp: '28' | ||
| elixir: '1.18' | ||
| lint: false | ||
|
|
||
| services: | ||
| typesense: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| name: CI v30.0 | ||
|
|
||
| on: | ||
| workflow_call: | ||
| pull_request: | ||
| branches: ["main"] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| # https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs | ||
| # Workflows that would otherwise be triggered using `on: push` or | ||
| # `on: pull_request` won't be triggered if you add any of the | ||
| # following strings to the commit message in a push, or the HEAD | ||
| # commit of a pull request: | ||
| # - [skip ci] | ||
| # - [ci skip] | ||
| # - [no ci] | ||
| # - [skip actions] | ||
| # - [actions skip] | ||
|
|
||
| test: | ||
| if: ${{ (github.event_name == 'push' || github.event_name == 'pull_request') && github.repository == 'jaeyson/open_api_typesense' }} | ||
| runs-on: ubuntu-latest | ||
| environment: review | ||
|
|
||
| env: | ||
| MIX_ENV: test | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| LATEST_TYPESENSE: '30.0' | ||
|
|
||
| strategy: | ||
| matrix: | ||
| include: | ||
| - typesense: '30.0' | ||
| otp: '25' | ||
| elixir: '1.14' | ||
| lint: false | ||
| - typesense: '29.0' | ||
| otp: '28' | ||
| elixir: '1.18' | ||
| lint: true | ||
|
|
||
| services: | ||
| typesense: | ||
| image: typesense/typesense:${{ matrix.typesense }} | ||
|
|
||
| steps: | ||
| - name: Checkout repo | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Check for misspellings | ||
| uses: codespell-project/actions-codespell@v2 | ||
|
Check warning on line 55 in .github/workflows/ci_v30.0.yml
|
||
|
|
||
| - name: Start Typesense | ||
| run: | | ||
| docker run -id \ | ||
| -p 8108:8108 \ | ||
| --name typesense \ | ||
| -v /tmp/typesense-data:/data \ | ||
| -v /tmp/typesense-analytics-data:/analytics-data \ | ||
| typesense/typesense:${{ matrix.typesense}} \ | ||
| --api-key xyz \ | ||
| --data-dir /data \ | ||
| --enable-search-analytics=true \ | ||
| --analytics-dir=/analytics-data \ | ||
| --analytics-flush-interval=60 \ | ||
| --analytics-minute-rate-limit=100 \ | ||
| --enable-cors | ||
|
|
||
| - name: Wait for Typesense to be healthy | ||
| shell: bash | ||
| run: | | ||
| start_time=$(date +%s) | ||
| timeout=30 | ||
| counter=0 | ||
| until curl -s http://localhost:8108/health | grep -q '"ok":true'; do | ||
| if [ $counter -eq $timeout ]; then | ||
| echo "Timed out waiting for Typesense to be healthy" | ||
| exit 1 | ||
| fi | ||
| echo "Waiting for Typesense to be healthy..." | ||
| sleep 1 | ||
| counter=$((counter + 1)) | ||
| done | ||
| end_time=$(date +%s) | ||
| elapsed=$((end_time - start_time)) | ||
| echo "Typesense healthcheck elapsed: ${elapsed}s" | ||
|
|
||
| - name: Setup Elixir/OTP | ||
| uses: erlef/setup-beam@v1 | ||
|
Check warning on line 93 in .github/workflows/ci_v30.0.yml
|
||
| with: | ||
| otp-version: ${{matrix.otp}} | ||
| elixir-version: ${{matrix.elixir}} | ||
|
|
||
| - name: Cache dependencies/builds | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| deps | ||
| _build | ||
| key: ${{ runner.os }}-typesense-${{ matrix.typesense}}-${{ matrix.otp}}-${{ matrix.elixir}}-mix-${{ hashFiles('**/mix.lock') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-typesense-${{ matrix.typesense}}-${{ matrix.otp }}-${{ matrix.elixir }}-mix- | ||
|
|
||
| - name: Install Dependencies | ||
| run: | | ||
| mix local.rebar --if-missing | ||
| mix local.hex --if-missing | ||
| mix deps.get | ||
|
|
||
| - name: Find unused dependencies | ||
| run: mix deps.unlock --check-unused | ||
| if: ${{ matrix.lint }} | ||
|
|
||
| - name: Check retired dependencies | ||
| run: mix hex.audit | ||
| if: ${{ matrix.lint }} | ||
|
|
||
| - name: Security audit of dependencies | ||
| run: mix deps.audit | ||
| if: ${{ matrix.lint }} | ||
|
|
||
| - name: Compile project | ||
| run: mix compile --all-warnings | ||
|
|
||
| - name: Run static analysis | ||
| run: mix credo --all --strict | ||
| if: ${{ matrix.lint }} | ||
|
|
||
| - name: Check format files | ||
| run: mix format --check-formatted | ||
| if: ${{ matrix.lint }} | ||
|
|
||
| - name: Restore PLT cache | ||
| id: plt_cache | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| key: | | ||
| plt-${{ runner.os }}-${{ steps.beam.outputs.otp-version }}-${{ steps.beam.outputs.elixir-version }}-${{ hashFiles('**/mix.lock') }} | ||
| restore-keys: | | ||
| plt-${{ runner.os }}-${{ steps.beam.outputs.otp-version }}-${{ steps.beam.outputs.elixir-version }}- | ||
| path: | | ||
| priv/plts | ||
| if: ${{ matrix.lint }} | ||
|
|
||
| - name: Create PLTs | ||
| if: ${{ steps.plt_cache.outputs.cache-hit != 'true' && matrix.lint }} | ||
| run: mix dialyzer --plt | ||
|
|
||
| - name: Save PLT cache | ||
| id: plt_cache_save | ||
| uses: actions/cache/save@v4 | ||
| if: ${{ steps.plt_cache.outputs.cache-hit != 'true' && matrix.lint }} | ||
| with: | ||
| key: | | ||
| plt-${{ runner.os }}-${{ steps.beam.outputs.otp-version }}-${{ steps.beam.outputs.elixir-version }}-${{ hashFiles('**/mix.lock') }} | ||
| path: | | ||
| priv/plts | ||
|
|
||
| - name: Dialyzer | ||
| run: mix dialyzer --format github --format dialyxir | ||
| if: ${{ matrix.lint }} | ||
|
|
||
| - name: Run tests | ||
| run: mix test --only ${{ matrix.typesense }}:true --only nls:true --trace | ||
|
|
||
| - name: Post test coverage to Coveralls | ||
| run: mix coveralls.github | ||
| if: ${{ matrix.lint && github.event_name == 'push' && github.ref == 'refs/heads/main' }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ Restful client for Typesense with adherence to Open API spec 3 (formerly Swagger | |
| [](https://app.codacy.com/gh/jaeyson/open_api_typesense/dashboard?utm_source=gh&utm_medium=referral&utm_content=&utm_campaign=Badge_grade) | ||
| [](https://codescene.io/projects/63240) | ||
|
|
||
| [](https://github.com/jaeyson/open_api_typesense/actions/workflows/ci_v30.0.yml) | ||
| [](https://github.com/jaeyson/open_api_typesense/actions/workflows/ci_v29.0.yml) | ||
| [](https://github.com/jaeyson/open_api_typesense/actions/workflows/ci_v28.0.yml) | ||
| [](https://github.com/jaeyson/open_api_typesense/actions/workflows/ci_v27.1.yml) | ||
|
|
@@ -16,7 +17,7 @@ Restful client for Typesense with adherence to Open API spec 3 (formerly Swagger | |
|
|
||
| [](https://github.com/jaeyson/open_api_typesense/pulls/app%2Fdependabot) | ||
| [](https://hexdocs.pm/open_api_typesense/license.html) | ||
| [](https://typesense.org/docs/30.0/api) | ||
|
|
||
| **Note**: the only place where ai is used/integrated is in PR reviews. I am NOT interested in adding/integrating ai generated code in my codebase, as this little library can be fit in my mental model. ai has it’s own great use case, it’s just that I wanted to be hands-on with these projects. | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): PLT cache keys reference
steps.beambut there is no step with that id, so the cache will not work as intendedsteps.beam.outputs.otp-versionandsteps.beam.outputs.elixir-versionwill be empty because theSetup Elixir/OTPstep has noid: beam, so the cache key will be malformed and hurt cache effectiveness. Either addid: beamto theerlef/setup-beamstep or switch the cache key to usematrix.otpandmatrix.elixirinstead.