Reduce object allocations in AudioListener#2501
Open
capdevon wants to merge 5 commits intojMonkeyEngine:masterfrom
Open
Reduce object allocations in AudioListener#2501capdevon wants to merge 5 commits intojMonkeyEngine:masterfrom
capdevon wants to merge 5 commits intojMonkeyEngine:masterfrom
Conversation
Member
|
I've reverted the changes to the existing getters. Since the listener isn't only an internal API, changing their behavior could break existing code, and because the defect isn't severe, it isn't worth risking hard-to-debug regressions for developers, imo. Instead, I added new getters that populate the passed store object (a pattern used frequently elsewhere in jME), and updated the Audio Renderer to use these new getters. I think this is a good resolution. |
riccardobl
approved these changes
Jan 13, 2026
Contributor
Author
|
Refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce object allocations when
ALAudioRendererupdate listener each time theCamerais moved:This pull request refactors the Listener class in the jMonkeyEngine audio system. The main changes include initializing the
location,velocity, androtationfields at declaration instead of in the constructor, removing redundant constructor assignments, and introducing reusableVector3finstances (left,up,direction) for direction calculations.Methods that return direction vectors now store results in these fields rather than creating new objects, improving memory efficiency and reducing unnecessary allocations. Overall, the changes streamline object management and optimize performance in the Listener class.
https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-core/src/main/java/com/jme3/audio/openal/ALAudioRenderer.java#L768