Add qFSP boundary mask to RSLC#246
Draft
bhawkins wants to merge 12 commits intoisce-framework:developfrom
Draft
Conversation
bhawkins
commented
Apr 7, 2026
Contributor
Author
bhawkins
left a comment
bhawkins
left a comment
There was a problem hiding this comment.
Only got part of the way through this PR in our meeting today. Comments so far:
| Dictionary specifying convergence parameters for geo2rdr solver. | ||
| Keys among {"tol_height", "time_start", "time_start"} | ||
| See isce3.geometry.geo2rdr_bracket | ||
| method: str |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| method: str | |
| method: str, optional |
| See isce3.geometry.geo2rdr_bracket | ||
| method: str | ||
| LUT2d interpolation method | ||
| b_error: bool |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| b_error: bool | |
| b_error: bool, optional |
Comment on lines
+1871
to
+1872
| log.warning("Internal calibration (INT_CAL) file was not provided " | ||
| "so unable to populate inputDataExceptionMask") |
Contributor
Author
There was a problem hiding this comment.
Need to think about the interaction with EAP on/off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
inputDataExceptionMaskin RSLC products for the LSAR qFSP-related exception codes. It handles all six possible qFSP exception codes. For now, the strategy to is locate the peaks of the AC table weights in the EL angle domain and use the EL-angle LUT to generate the mask. This mask is in the raw data domain, so it's resampled to the RSLC grid using reskew LUTs. (These could be used to reskew other tables in some future PR, too). I added a vectorizedLUT2d::evaloverload to make this faster.Eyeballing the plots for the case I tested on, I'm not sure the mask covers everything where there's obvious residual phase. So maybe instead of defining the overlap region as peak-to-peak, we should be more conservative and use a -6 dB threshold or something. I hope folks can do some InSAR tests to help figure out the best approach.
Note that the mask is populated based on the contents of the input L0B
hasInputDataExceptionflag, so that must be populated to see any effect.Another question is what to do about mixed-mode frames where one L0B has a qFSP slip and its neighbor doesn't. For now, the qFSP overlap region is marked invalid for the entirety of the output product.