[irods/python-irodsclient#726] Add Ruff workflows #25
Conversation
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Good stuff. Let's remove the pound for now.
Please go through and document the python file so that others can understand the thinking and implementation. Let's capture requirements in the source file too, if any.
Do we have to worry about any compatibility issues as new versions of ruff are released?
What else do we need to be aware of when it comes to using this workflow in projects?
| - name: Checkout Workflow Repository | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| repository: SwooshyCueb/irods_reusable_github_workflows |
There was a problem hiding this comment.
| repository: SwooshyCueb/irods_reusable_github_workflows | |
| repository: irods/irods_reusable_github_workflows |
| - name: Checkout Workflow Repository | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| repository: SwooshyCueb/irods_reusable_github_workflows |
There was a problem hiding this comment.
| repository: SwooshyCueb/irods_reusable_github_workflows | |
| repository: irods/irods_reusable_github_workflows |
| git_diff_args += [ | ||
| "diff", | ||
| "HEAD", | ||
| #"--cached", |
There was a problem hiding this comment.
I've left it because LLVM uses it in their wrappers, but it breaks ours. I haven't figured out why.
There was a problem hiding this comment.
Okay. Let's open an issue for it and put a TODO(#N): around it.
We may have to adjust project configurations as new rules are added or removed. Beyond that, I think the project is mature enough that we would have plenty of warning for any breaking changes.
Nothing comes to mind. |
2 participants
In service of irods/python-irodsclient#726