Open
Conversation
Adds 03-srv6-bgp-ipv4.yml: IPv6-only core with BGP+SRv6, eBGP for SID prefix exchange with the core, and IPv4 overlay validation. Made-with: Cursor
- Configure neighbor activate from srv6.bgp and srv6.igp (IPv6 eBGP when igp includes bgp) - Add bgp to srv6.igp valid_values for BGP-only underlay Made-with: Cursor
Enable features.srv6.bgp for FRR device (BGP-based SRv6 underlay). Made-with: Cursor
- frr.bgp.j2: when srv6.igp includes bgp, set locator on SRv6 dummy and originate locator in IPv6 unicast; add encapsulation-srv6 on neighbors; render srv6.bgp AFs with sid export auto; keep VPN AFs when srv6.vpn - frr.j2: create vrf-srv6; include BGP SRv6 block when srv6.bgp is set Made-with: Cursor
Use SRv6_VRF_DEV; create vrf-srv6 only when srv6.igp includes bgp. Made-with: Cursor
- Expand bgp.session plugin comment for PE transit via P AS - Set defaults.bgp.warnings.missing_igp: False (BGP-only underlay) Made-with: Cursor
IPv6 customer loopbacks and overlay (srv6.bgp ipv6), BGP-only underlay with eBGP SID exchange and allowas_in on core links; IPv6 ping validation. Made-with: Cursor
Made-with: Cursor
Remove dead srv6.vpn lookup and stale comment; activation logic is unchanged. Made-with: Cursor
Owner
|
Nice starting point, thanks a million! Unfortunately, you mixed two completely independent things in a single PR:
At the very minimum, this should be split in two independent PRs, and I'm sure there are other devices out there supporting BGP as the routing protocol for SRv6 locators, so it would be nice to have two interoperable implementations (and yeah, I know that's a lot to wish for). Once I got a bit of time (and some willpower), I can do the refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the upgrade to the latest FRR 10.6 release, we can now do SRv6 with BGP as IGP
Conceptually this still somewhat mixes EBGP as an IGP underlay for SRv6 and BGP v4/v6 in the overlay, we may want to clean that up. I'm sharing an early draft with key knobs to enable this use case (and I know how much you love IBGP-over-EBGP designs, that could be changed too of course)