Conversation
chfast
requested review from
Copilot and
rodiazet
and removed request for
Copilot
Member
Author
|
Using w=5 window size gives mixed results, probably depends on the scalar size. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1419 +/- ##
==========================================
- Coverage 81.68% 81.60% -0.08%
==========================================
Files 152 153 +1
Lines 13576 13697 +121
Branches 3217 3264 +47
==========================================
+ Hits 11089 11178 +89
- Misses 343 344 +1
- Partials 2144 2175 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR replaces the Straus-Shamir multi-scalar multiplication (MSM) algorithm with a windowed Non-Adjacent Form (wNAF) method for elliptic curve cryptography operations, achieving ~13% performance improvement. The change introduces a NAF helper class for encoding scalars, implements wNAF recoding with a conservative window size of 4, and adds comprehensive unit tests for the NAF encoding/decoding functionality.
Key changes:
- Implemented wNAF-based MSM algorithm with precomputed lookup tables for odd multiples
- Added NAF class for storing and manipulating NAF representations
- Created unit tests covering various window sizes, edge cases, and fuzzing for uint256 values
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/unittests/crypto_wnaf.cpp | New unit tests for NAF encoding/decoding with comprehensive test cases including edge cases and fuzzing |
| test/unittests/CMakeLists.txt | Added crypto_wnaf.cpp to the test sources |
| lib/evmone_precompiles/ecc.hpp | Replaced Straus-Shamir MSM with wNAF-based implementation, added NAF class and helper functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chfast
force-pushed
the
crypto/wnaf
branch
2 times, most recently
from
41fd8e3 to
afbdec8
Compare
- Replace Straus-Shamir MSM with windowed NAF (sliding window) method.
- Set conservative initial windows size w=4.
- Add NAF helper class, wNAF recoding, and shared MSM utility.
- Cover NAF encoding/decoding with new crypto_wnaf unit tests.
### Benchmark results
```
│ o/ec.txt │ o/ec-wnaf-4.txt │
│ sec/op │ sec/op vs base │
precompile<PrecompileId::ecrecover,_evmmax_cpp>-14 126.3µ ± 0% 111.0µ ± 0% -12.13% (p=0.001 n=11)
precompile<PrecompileId::ecmul,_evmmax_cpp>-14 53.91µ ± 0% 46.83µ ± 0% -13.13% (p=0.000 n=11)
precompile<PrecompileId::p256verify,_evmone_cpp>-14 124.4µ ± 90% 107.2µ ± 90% -13.83% (p=0.028 n=11)
geomean 94.61µ 82.28µ -13.03%
│ o/ec.txt │ o/ec-wnaf-4.txt │
│ gas/op │ gas/op vs base │
precompile<PrecompileId::ecrecover,_evmmax_cpp>-14 30.00k ± 0% 30.00k ± 0% ~ (p=1.000 n=11) ¹
precompile<PrecompileId::ecmul,_evmmax_cpp>-14 60.00k ± 0% 60.00k ± 0% ~ (p=1.000 n=11) ¹
precompile<PrecompileId::p256verify,_evmone_cpp>-14 69.00k ± 0% 69.00k ± 0% ~ (p=1.000 n=11) ¹
geomean 49.89k 49.89k +0.00%
¹ all samples are equal
│ o/ec.txt │ o/ec-wnaf-4.txt │
│ gas/s │ gas/s vs base │
precompile<PrecompileId::ecrecover,_evmmax_cpp>-14 23.75M ± 0% 27.04M ± 0% +13.86% (p=0.000 n=11)
precompile<PrecompileId::ecmul,_evmmax_cpp>-14 111.3M ± 0% 128.1M ± 1% +15.09% (p=0.000 n=11)
precompile<PrecompileId::p256verify,_evmone_cpp>-14 55.39M ± 0% 64.30M ± 0% +16.09% (p=0.000 n=11)
geomean 52.71M 60.62M +15.01%
│ o/ec.txt │ o/ec-wnaf-4.txt │
│ cycles/op │ cycles/op vs base │
precompile<PrecompileId::ecrecover,_evmmax_cpp>-14 503.5k ± 1% 441.4k ± 0% -12.33% (p=0.000 n=11)
precompile<PrecompileId::ecmul,_evmmax_cpp>-14 214.9k ± 0% 186.5k ± 0% -13.22% (p=0.000 n=11)
precompile<PrecompileId::p256verify,_evmone_cpp>-14 495.8k ± 90% 427.4k ± 0% -13.79% (p=0.010 n=11)
geomean 377.1k 327.7k -13.11%
│ o/ec.txt │ o/ec-wnaf-4.txt │
│ instructions/op │ instructions/op vs base │
precompile<PrecompileId::ecrecover,_evmmax_cpp>-14 1.537M ± 0% 1.382M ± 0% -10.12% (p=0.000 n=11)
precompile<PrecompileId::ecmul,_evmmax_cpp>-14 737.5k ± 0% 663.6k ± 0% -10.03% (p=0.000 n=11)
precompile<PrecompileId::p256verify,_evmone_cpp>-14 1.552M ± 0% 1.386M ± 0% -10.74% (p=0.000 n=11)
geomean 1.207M 1.083M -10.29%
```
Member
Author
|
There is wNAF overflow bug, probably not discovered by ECC because we don't use max 256-bit scalar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark results