Avoid Sendable data-race diagnostic in API completion#22
Merged
silvanocerza merged 1 commit intoipinfo:mainfrom Mar 26, 2026
Merged
Avoid Sendable data-race diagnostic in API completion#22silvanocerza merged 1 commit intoipinfo:mainfrom
silvanocerza merged 1 commit intoipinfo:mainfrom
Conversation
Avoid DispatchQueue.main.async wrapping in requestAPI to prevent Swift 6 Sendable/data-race diagnostics when capturing completion.
silvanocerza
approved these changes
Mar 26, 2026
Contributor
silvanocerza
left a comment
silvanocerza
left a comment
There was a problem hiding this comment.
Thanks! 🙏
Tests are failing because PRs from forks don't have access to secrets.
Locally everything is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mainqueue directlyDispatchQueue.main.asyncaroundcompletionContext
Xcode/Swift 6 strict concurrency can report:
Sending 'completion' risks causing data racesinService.requestAPI.This patch keeps callback delivery on the main thread via Alamofire's response queue and avoids capturing
completionin an extra sendable closure.