Create devcontainer - #211
Merged
Merged
Conversation
Javascript size report
|
For Codespaces and safer local agent usage.
The official ghcr.io/anthropics/devcontainer-features/claude-code feature installs itself as root via npm, and root can't resolve mise's user-scoped shims for node/npm (mise reports "npm is not a valid shim"). Install the Claude Code CLI ourselves in the same Dockerfile layer as `mise install`, where mise is already correctly activated as vscode. Also stop symlinking individual mise-managed binaries into /usr/local/bin — npm's own bin script computes sibling paths like ../lib/node_modules relative to its real directory, which breaks through a single-file symlink. Symlink the containing install directories instead and put those on PATH, which works for any caller (root included) since the kernel resolves the ".." after the symlink itself. Verified end-to-end: rust_test, py_test (3.12-3.14), js_build, js_test, and js_test_wasm (headless Chrome via wasm-pack) all pass inside the built container.
…build The wasm_size job checks out github.base_ref into a nested base/ checkout and builds from base/js. mise's version resolution stops at the nearest ancestor config, and main's mise.toml (pre-migration) only declares node — so rust/wasm-pack are invisible from base/js and the shim errors "No version is set for shim: wasm-pack". Write the already-installed versions to mise's global config right after installing them (mise's own suggested remedy), which is consulted as a fallback below the nearest project config. Confirmed via CI run 29113346137: Build npm package, Build demo, and Test all passed; only WASM size check failed, exactly as diagnosed.
abkfenris
marked this pull request as ready for review
July 10, 2026 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Codespaces and safer local agent usage.