chore(i18n, usage): rename playground partials to .mdx and update imports - #4663
Open
thetaPC wants to merge 2 commits into
Open
chore(i18n, usage): rename playground partials to .mdx and update imports#4663thetaPC wants to merge 2 commits into
thetaPC wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
marked this pull request as ready for review
August 25, 2026 21:51
2 tasks
ShaneK
requested changes
Aug 26, 2026
| 場合によっては、アプリケーションロジック内で現在の Ionic モードにプログラム的にアクセスする必要があるかもしれません。これは、条件付き動作を適用したり、特定のアセットを取得したり、アクティブなスタイリングモードに基づいて他のアクションを実行したりするのに役立ちます。 | ||
|
|
||
| import IonicMode from '@site/static/usage/v9/config/mode/index.md'; | ||
| import IonicMode from '@site/static/usage/v9/config/mode/index.mdx'; |
Member
There was a problem hiding this comment.
Same five @site/docs/developing/config partials as the thread on #4662, so I won't repeat the ask here. Could that card also mention that this branch needs a companion whenever they flip? Same reason as this pair.
Contributor
Author
There was a problem hiding this comment.
Added it to the Jira ticket
ShaneK
approved these changes
Aug 26, 2026
ShaneK
left a comment
Member
There was a problem hiding this comment.
Oops, the other comment was supposed to be approve 🤦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
The translated pages import playground partials by explicit path, for example
@site/static/usage/v9/accordion/basic/index.md. Each of those partials imports thePlaygroundcomponent and renders JSX, so they are MDX files carrying a.mdextension. Docusaurus is moving toward parsing.mdas plain CommonMark, which would turn those imports into literal text and render every playground blank.The companion PR on main renames the same partials there. Because this branch is a full fork of the repository rather than a prose only branch, it carries its own copy of
static/usage, and@siteresolves against whichever checkout is being built. That means the rename has to happen here too, not just on main.What is the new behavior?
Two matching halves.
The 432
index.mdpartials understatic/usage/v9are renamed toindex.mdx, and the 441 references to them across 76 files underdocsare updated to match.Three things are deliberately left alone.
The 19
@site/static/imgreferences are unaffected by the rename.The 5
@site/docs/developing/configpartial imports stay as.md. Those files are renamed later in this series, and changing them here would break them. That work is tracked on the card, including the fact that this branch needs a matching rename when they flip.static/usage/v6,v7, andv8keep their.mdpartials, andversioned_docsis not touched at all. Renaming them would break this branch in the other direction, because its ownversioned_docsimports those partials and preview builds renderversion-v8from them. The trees stay internally consistent.Does this introduce a breaking change?
Other information
Merge this after the companion PR on main. There is no time pressure once that lands, but the order does matter.
That PR adds a
resolve.extensionAliasentry mapping.mdto.mdx, so main's tree keeps serving the old names after its rename. Any Japanese page still importing.mdresolves correctly, which means this branch can follow at any point and anything merging to main in between is safe. The alias only works in that direction though: it rewrites.mdrequests to find.mdxfiles, not the reverse. Merging this branch first would leave these imports asking for.mdxfiles main does not have yet, and nothing would rescue that.Only the current version is translated here, which is why nothing under
versioned_docsneeds updating for the Japanese site.scripts/i18n.shextracts only this branch'sdocsdirectory into the localized content path, so every older version falls back to main's English pages. Theversioned_docscopies on this branch are untranslated snapshots that are never built or served: v8 contains Japanese text in 1 of 257 files and v7 in 0 of 241. Main's ownversioned_docs/version-v8is what actually serves those pages, and the companion PR already updates it.Verification performed locally: a full build with the same command the preview deploy runs completes successfully, reporting 0 errors, 0 warnings, 0 unresolved modules, and 0 broken links. The two broken anchors it reports both predate this work and are unrelated to imports. Prettier reports no formatting changes.
The gap state was also verified directly, by building
--locale jafrom the companion branch combined with this branch's prose in its unmerged form. Without the alias that build fails with 428 unresolved modules. With it, the same build completes and emits 2298 pages with playgrounds rendering.How to test
Open each page below and confirm the playgrounds still render. This branch renames its own copy of the v9 partials, so a failure shows up as a missing or blank playground rather than as broken prose.
.md, so this page should look exactly as it does today.On each page, check that:
Every playground appears, with its live demo loading in the embedded frame.
Switching between the Angular, React, Vue, and JavaScript tabs shows the code for each. A playground can render correctly while its tabs come up empty, so this is the only step that confirms the code snippets themselves loaded.
No raw text such as an
importline or a literal component tag is visible anywhere in the rendered page.One limit worth knowing. This preview builds a single English locale from this branch's own files, which is why the pages show Japanese prose under an English locale. The way the Japanese site is actually assembled in production, main's tree combined with this branch's prose, is not reproducible in any preview, which is why that path was verified locally instead.