[tooling] Fix image build time - #1670
Open
BenjaminPelletier wants to merge 3 commits into
Open
Conversation
BenjaminPelletier
marked this pull request as ready for review
August 26, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current Dockerfile installs dev dependencies after adding the repo content to the image which means any change in any file in the repo triggers a
uv syncin the dev image even if no dev dependencies have changed. This is extremely oppressive since theuv syncoperation can take almost 3 minutes andmake formattypically builds theimage-devimage twice (the second time after making formatting adjustments).This PR restructures Dockerfile to only build one target, but to use an argument to specify which dependencies image the final image is based on (normal or dev dependencies). Both earlier stages are built prior to adding repo content so they don't need to be rebuilt when no dependencies are changed.