test(vscode): pin the settings shape that actually exists in the wild - #190
Merged
Conversation
The SKILLS session swept its tree for #187 exposure and found three .vscode/settings.json of one shape, none of which my tests covered: {"objectscript.conn": {"active": true, "server": "workshop-iris", "ns": "HOSPITAL"}, "objectscript.export": {"folder": "src", "atelier": true}} active:true, a server NAME, and no intersystems.servers map at all — because Server Manager keeps the server definition in USER-scope settings, which this binary does not read. That is the commonest real entry, and under 0.17.0's precedence it is now reached at step 4, ahead of the port scan that currently serves those directories. a_named_server_with_no_matching_entry_is_not_configured covers the NEIGHBOURING case: map present, key absent. This shape takes a different sub-expression — intersystems_servers.as_ref() yields None before .get() is ever reached — and two branches that should agree are not evidence that they do. Behaviour was already verified at the wire on the shipped 0.17.0 binary before this test existed: 0 warnings, the scans ran, `✓ Compiled`. The branch simply had no test. Distinguishing mutation control, not just a mutation: making a missing map skip the named path and fall through to direct host/port fails ONLY the new test (13 passed, 1 failed) with "reported a missing password for a server that was never resolved". A mutation on the shared match arm would have killed both tests and proved nothing about coverage; this one isolates the branch. Tests only — no behaviour change, no version bump. #187 stays open for the search-path gap this shape is a symptom of: user-scope settings are still not read. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SKILLS session swept its tree for #187 exposure and found three
.vscode/settings.jsonof one shape, none of which the test suite covered:{ "objectscript.conn": { "active": true, "server": "workshop-iris", "ns": "HOSPITAL" }, "objectscript.export": { "folder": "src", "atelier": true } }active: true, a server name, and nointersystems.serversmap at all — because Server Manager keeps the server definition in USER-scope settings, which this binary does not read. That is the commonest real entry in the wild, and under 0.17.0's precedence it is now reached at step 4, ahead of the port scan that currently serves those directories.Why the neighbouring test didn't already cover it
a_named_server_with_no_matching_entry_is_not_configuredcovers map present, key absent. This shape takes a different sub-expression:intersystems_servers.as_ref()yieldsNonebefore.get()is ever reached. Two branches that ought to agree are not evidence that they do.Evidence
Behaviour was verified at the wire on the shipped 0.17.0 binary before this test existed — 0
#187warnings, the scans ran,✓ Compiled: T.cls, with a no-.vscodecontrol returning zero. The branch simply had no test.Distinguishing mutation control. Making a missing map skip the named path and fall through to direct host/port fails only the new test:
A mutation on the shared
matcharm would have killed both tests and proved nothing about coverage. This one isolates the branch, which is the whole claim being made.Scope
Tests only. No behaviour change, no version bump. Gate run as one command:
cargo fmt --all -- --check && cargo clippy --workspace --all-targets -- -D warnings && cargo test --workspace→ 47 suites green.Issue 187 stays open for the search-path gap this shape is a symptom of: user-scope VS Code settings are still not read, and there is no keychain reader.
🤖 Generated with Claude Code