Repository navigation
Conversation
Tokens. The topnav's own palette (--white, --grey13 to --grey80, --greya0, --grey6f, --errorYellow) now points at design tokens, and every camelCase role keeps its name. --linkColor reads --ia-theme-link-color first. The font, the donate heart, the hamburger and the Wayback search field use tokens too. Focus. Every outline: none in the topnav is gone, and each part takes one shared focus ring (focus-styles.ts) in its dark-surface color, drawn inside the edge in the bar and in menu rows so nothing clips it. A test checks every focusable part shows it; on the old code eleven did not. Spec colors (navigation.md). Labels, glyphs and the account links are #ccc instead of #999; an open media type sits on #333 with its D-43 hue; the logo link has a color instead of the browser's blue; the media menu's column headings take the menu's group heading style, in place of a weight-100 hairline. The wide account menu is the dark menu panel (D-41), with the overlay for hover in place of white on #4b64ff, and rows at least 30px tall, 44px to a finger. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## WEBDEV-9043-tokens-3b #200 +/- ##
======================================================
Coverage 91.31% 91.32%
======================================================
Files 235 236 +1
Lines 7465 7466 +1
Branches 1639 1639
======================================================
+ Hits 6817 6818 +1
Misses 309 309
Partials 339 339 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… ring - The wide menu's rows are flex, so the absolutely placed callout badge landed over the label; it now sits in flow after it. - Row rings are inset at every width; the narrow menu's scrolling list clipped an outset ring. - The Wayback search field shows a ring, inset since the field clips. - Row heights and the panel radius use topnav units, not rem, so the menu stays independent of the page's root font size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the phased move of the style guide into elements. Based on #199, which adds the
text-inverse-tertiarytoken this uses; #199 is based on #195. Every visible change here was previewed and approved before it was written.Focus rings on every stop
Most of the homepage's first keyboard stops had no focus indicator: 13
outline: nonerules across the topnav's parts. That's the first item in the navigation spec's "What must change".focus-styles.ts: 2px, in the dark-surface focus color#9aa8ff.ia-topnav-focus.test.tsfocuses every rendered focusable part and fails if any shows no ring. On the old code, eleven failed, starting with the main menu button.Spec colors (
docs/components/navigation.md)#999/#aaa--ia-color-text-inverse-secondary#ccc#474747with the pre-D-43 hues#333, its--ia-color-mediatype-*hue (D-43)rgb(0,0,238)--ia-color-text-inverse#ccc(5.79:1)#bca38eborder,#8e8e8eplaceholder#666border and secondary textThe wide account menu is the dark panel (D-41)
#4b64ff.#2c2c2c, 4px radius, overlay shadow, white rows.Tokens
The topnav's own palette now points at tokens:
--whitetext-inverse--grey13,--grey20,--grey28surface-chrome,surface-chrome-secondary,border-inverse--grey60,--grey80,--greya0text-inverse-tertiary, thentext-inverse-secondaryfor the last two--grey6flegacy-gray-550--errorYellowaction-warning-fill(#ffb000, 8.7:1 on#222)Other changes:
<ia-topnav>with them still works.--linkColornow reads--ia-theme-link-colorfirst; before, it was hard-coded and couldn't be themed.--ia-font-family-base.--ia-color-brand-donate.#999.Not changed
--topnavUnit--, breakpoints and hit areas.#fee257) stays as it is; there's no token for it yet.navigation.md"live component" notes. The docs aren't on this branch, so they'll be updated in a docs follow-up once WEBDEV-9043: Bring the style guide's pages and docs into the demo #196 is in.Verification
#ccc.🤖 Generated with Claude Code