[CMake][NFC] Remove dead code add_llvm_external_project(libclc)#21947
Open
wenju-he wants to merge 1 commit intointel:syclfrom
Open
[CMake][NFC] Remove dead code add_llvm_external_project(libclc)#21947wenju-he wants to merge 1 commit intointel:syclfrom
wenju-he wants to merge 1 commit intointel:syclfrom
Conversation
It was added in 7a9a425. libclc has now switched to runtime build.
wenju-he
changed the title
maksimsab
approved these changes
May 7, 2026
Contributor
maksimsab
left a comment
maksimsab
left a comment
There was a problem hiding this comment.
I don't see any blockers for that.
Contributor
|
What is |
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
It was previously built as a llvm project (built using host compiler). Now it is built as a llvm runtime (built using just-built clang), see Lines 232 to 237 in 4115fc0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was added in 7a9a425.
libclc has now switched to runtime build.