[SYCL][NFC] Remove duplicate UR manifest_file generation#21940
Open
wenju-he wants to merge 2 commits intointel:syclfrom
Open
[SYCL][NFC] Remove duplicate UR manifest_file generation#21940wenju-he wants to merge 2 commits intointel:syclfrom
wenju-he wants to merge 2 commits intointel:syclfrom
Conversation
The same manifest file was being generated using identical cmake command
in two places: BuildUnifiedRuntime.cmake and sycl/CMakeLists.txt.
The redundancy caused cmake error
```
Attempt to add a custom rule to output
build/tools/sycl/install_manifest_ur_adapter_level_zero.txt.rule
which already has a custom rule.
```
if the cmake commands (generating the manifest file) in both locations
diverge, e.g. when cmake command in sycl/CMakeLists.txt is updated.
cperkinsintel
approved these changes
May 6, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same manifest file was being generated using identical cmake command in two places: BuildUnifiedRuntime.cmake and sycl/CMakeLists.txt.
The redundancy caused cmake error
if the cmake commands (generating the manifest file) in both locations diverge, e.g. when cmake command in sycl/CMakeLists.txt is updated.
ur_adapter_* install command in deploy-sycl-toolchain still installs
debug DLL on Windows because install component is the same.