[SYCL-Unit]Fix segfault in DeviceGlobalProgramHandle test due to static initialization order#21921
Conversation
…ic initialization order Fix regression introduced by 1ae0fe6. The test was calling device_global_map::add() during static initialization (in generateHandleTestImage() which was used to initialize g_Imgs array). This caused a segfault because device_global_map::add() tries to access ProgramManager via GlobalHandler::instance().getProgramManager(), but the GlobalHandler's member variables (specifically the SpinLock in InstWithLock<ProgramManager>) may not be fully initialized yet during static initialization, leading to undefined behavior. The fix moves the device_global_map::add() call from the static initialization path into the test fixture's SetUp() method, ensuring it runs during test execution when all runtime components are properly initialized. This is a classic static initialization order fiasco where the order of initialization between translation units is undefined, and we cannot guarantee that GlobalHandler will be fully initialized before the test's static initializers run. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by 1ae0fe6.
The test was calling device_global_map::add() during static initialization
(in generateHandleTestImage() which was used to initialize g_Imgs array).
This caused a segfault because device_global_map::add() tries to access
ProgramManager via GlobalHandler::instance().getProgramManager(), but
the GlobalHandler's member variables (specifically the SpinLock in
InstWithLock) may not be fully initialized yet during
static initialization, leading to undefined behavior.
The fix moves the device_global_map::add() call from the static
initialization path into the test fixture's SetUp() method, ensuring
it runs during test execution when all runtime components are properly
initialized.
This is a classic static initialization order fiasco where the order
of initialization between translation units is undefined, and we
cannot guarantee that GlobalHandler will be fully initialized before
the test's static initializers run.
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com