[UR] Extend memory-migrate tests#21901
Draft
kweronsx wants to merge 1 commit intointel:syclfrom
Draft
Conversation
kweronsx
force-pushed
the
add-memory-migrate-tests
branch
2 times, most recently
from
25edc08 to
9d64ec3
Compare
PatKamin
approved these changes
May 5, 2026
kswiecicki
reviewed
May 5, 2026
kweronsx
force-pushed
the
add-memory-migrate-tests
branch
from
9d64ec3 to
773a0e7
Compare
kswiecicki
reviewed
May 7, 2026
| ur_event_handle_t last_event = write_event; | ||
| for (auto i = 0u; i < iterations_per_thread; ++i) { | ||
| ur_event_handle_t kernel_event; | ||
| ASSERT_SUCCESS(urEnqueueKernelLaunchWithArgsExp( |
Contributor
There was a problem hiding this comment.
There's a race here, 8 threads are submitting the same kernel on the same buffer, each incrementing the buffer by 1. The kernels are properly ordered only in regards to a single thread.
You could keep track of an event from the last submitted kernel and use it as dependency when submitting the next kernel. Since multiple threads would be accessing it, you probably need a lock.
kweronsx
force-pushed
the
add-memory-migrate-tests
branch
from
773a0e7 to
e9166f1
Compare
Resume work on intel#20165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resume work on #20165