fix: reimplements firstExact match in legacy search.#3864
Draft
awildturtok wants to merge 3 commits intodevelopfrom
Draft
fix: reimplements firstExact match in legacy search.#3864awildturtok wants to merge 3 commits intodevelopfrom
awildturtok wants to merge 3 commits intodevelopfrom
Conversation
thoniTUB
approved these changes
Mar 27, 2026
Collaborator
thoniTUB
left a comment
thoniTUB
left a comment
There was a problem hiding this comment.
Habe die bei solr noch hinzugefügt, dass die Ergebnisse nach sourcePriority sortiert werden.
Der neue Methodenname kann denke ich jetzt wieder raus, weil wir die fehlerhafte Methode nicht nutzen.
Kann ansonten gemergt werden, wenn das bereinigt ist
Comment on lines
295
to
316
| @Override | ||
| public ConceptsProcessor.ExactFilterValueResult findExact(SelectFilter<?> filter, List<String> searchTerms) { | ||
| final List<FrontendValue> out = new ArrayList<>(); | ||
| // search in the full text engine | ||
| final Set<String> openSearchTerms = new HashSet<>(searchTerms); | ||
|
|
||
|
|
||
| for (final Iterator<String> iterator = openSearchTerms.iterator(); iterator.hasNext(); ) { | ||
|
|
||
| final String searchTerm = iterator.next(); | ||
| final List<FrontendValue> results = findExact(filter, searchTerm); | ||
|
|
||
| if (results.isEmpty()) { | ||
| continue; | ||
| } | ||
|
|
||
| iterator.remove(); | ||
| out.addAll(results); | ||
| } | ||
|
|
||
| return new ConceptsProcessor.ExactFilterValueResult(out, openSearchTerms); | ||
| } |
Collaborator
There was a problem hiding this comment.
Du kannst die Methode einfach wegwerfen, wir brauchen nicht für einen Wert nicht mehrere Ergebnisse
Comment on lines
+372
to
+376
| @Override | ||
| public ConceptsProcessor.ExactFilterValueResult findFirstExact(SelectFilter<?> filter, List<String> searchTerms) { | ||
| throw new NotImplementedException(); //TODO | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Kann dann auch wieder weg
Comment on lines
+89
to
+98
| /** | ||
| * Query for an exact matching {@link FrontendValue}, per search term return only the first match by priority of search sources. | ||
| * | ||
| * Matches {@link FrontendValue#getValue()} or {@link FrontendValue#getLabel()} but case-insensitive. | ||
| * @param filter The filter to the resulting value must correspond to (domain of the {@link FrontendValue}) | ||
| * @param searchTerms The exact terms to match | ||
| * @return A container with the exact matches and unmatched values. | ||
| */ | ||
| ConceptsProcessor.ExactFilterValueResult findFirstExact(SelectFilter<?> filter, List<String> searchTerms); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.