fix: duplicate tooltips showing on header action buttons#1584
Open
anantps926 wants to merge 2 commits intoinfinitered:masterfrom
Open
fix: duplicate tooltips showing on header action buttons#1584anantps926 wants to merge 2 commits intoinfinitered:masterfrom
anantps926 wants to merge 2 commits intoinfinitered:masterfrom
Conversation
anantps926
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn build-and-test:localpassesREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
This PR fixes the bug #1583 .
Problem
When hovering over header action buttons (e.g. the “Reverse Order” icon), two identical tooltips appear (stacked). This is due to multiple
<ReactTooltip />instances mounting for the samedata-tiptrigger.Fix Summary
<ReactTooltip />is mounted (e.g. in the root or header component)data-for="tooltip-id"on trigger elements to bind them to that shared tooltip instance