feat(asyncStorage): support RegEx and add pattern string match to ignore async plugin key#1559
Open
JDMathew wants to merge 3 commits intoinfinitered:masterfrom
Open
Conversation
Contributor
Author
|
@joshuayoes anyway you could update this with a trust check and give it a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn build-and-test:localpassesREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
This PR improves the asyncStorage() ignore functionality by adding support for regular expression patterns alongside existing string patterns. It also allows existing string patterns to get a partial match ignoring any keys that partially match.
Changes:
Benefits:
Anecdote:
My personal use case was that aws amplify was storing tokens in AsyncStorage under key names I don't have control of this would be something like
@MemoryStorage:CognitoIdentityServiceProvider.4589348z&...where I can now pattern match against@MemoryStorage:CognitoIdentityServiceProvider.