This repository was archived by the owner on May 25, 2023. It is now read-only.
Fuzz IP.Is<property>() methods against stdlib net.IP equivalents#182
Open
moreati wants to merge 1 commit intoinetaf:mainfrom
Open
Fuzz IP.Is<property>() methods against stdlib net.IP equivalents#182moreati wants to merge 1 commit intoinetaf:mainfrom
moreati wants to merge 1 commit intoinetaf:mainfrom
Conversation
Contributor
Author
|
Found 4 cases, again I'm not sure if a discrepancy is a bug or a facet I've not understood. |
josharian
approved these changes
May 24, 2021
Collaborator
josharian
left a comment
josharian
left a comment
There was a problem hiding this comment.
Nice! Please file issues for the mismatches so that we can discuss there.
Happy to merge this (with minor tweaks) once we've either fixed the underlying issues or tweaked the fuzz function to account for the legitimate mismatches. (I hope it's the former.)
The intent is to find discrepancies between netaddr.IP and net.IP. These don't necessarily indicate a bug (in either), but it's better to find them and explicitly document/exclude them. Signed-off-by: Alex Willmer <alex@moreati.org.uk>
Contributor
Author
|
Test jig for inspecting discrepancies https://play.golang.org/p/u7C8wFvPSA4 |
This was referenced May 25, 2021
Collaborator
|
@moreati I just discovered this was still open and unmerged. Sorry about that. Any reason I shouldn't merge now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to find discrepancies between netaddr.IP and net.IP. These don't necessarily indicate a bug (in either), but it's better to find them and explicitly document/exclude them.